Rename get_resolver -> wrap_resolve and fix tests

pull/1086/head v3.0.0b5
Jonathan Kim 2 years ago
parent 62f95f2858
commit da9f41c295
  1. 4
      graphene_django/fields.py
  2. 4
      graphene_django/filter/tests/test_fields.py
  3. 3
      graphene_django/tests/test_query.py
  4. 6
      graphene_django/tests/test_utils.py
  5. 2
      setup.py

@ -58,7 +58,7 @@ class DjangoListField(Field):
return queryset
def get_resolver(self, parent_resolver):
def wrap_resolve(self, parent_resolver):
_type = self.type
if isinstance(_type, NonNull):
_type = _type.of_type
@ -217,7 +217,7 @@ class DjangoConnectionField(ConnectionField):
return on_resolve(iterable)
def get_resolver(self, parent_resolver):
def wrap_resolve(self, parent_resolver):
return partial(
self.connection_resolver,
parent_resolver,

@ -417,12 +417,14 @@ def test_global_id_field_relation_with_filter():
class Meta:
model = Reporter
interfaces = (Node,)
fields = "__all__"
filter_fields = ["first_name", "articles"]
class ArticleFilterNode(DjangoObjectType):
class Meta:
model = Article
interfaces = (Node,)
fields = "__all__"
filter_fields = ["headline", "reporter"]
class Query(ObjectType):
@ -472,12 +474,14 @@ def test_global_id_field_relation_with_filter_not_valid_id():
class Meta:
model = Reporter
interfaces = (Node,)
fields = "__all__"
filter_fields = ["first_name", "articles"]
class ArticleFilterNode(DjangoObjectType):
class Meta:
model = Article
interfaces = (Node,)
fields = "__all__"
filter_fields = ["headline", "reporter"]
class Query(ObjectType):

@ -1122,6 +1122,7 @@ def test_connection_should_limit_after_to_list_length():
class Meta:
model = Reporter
interfaces = (Node,)
fields = "__all__"
class Query(graphene.ObjectType):
all_reporters = DjangoConnectionField(ReporterType)
@ -1166,6 +1167,7 @@ def test_should_return_max_limit(graphene_settings):
class Meta:
model = Reporter
interfaces = (Node,)
fields = "__all__"
class Query(graphene.ObjectType):
all_reporters = DjangoConnectionField(ReporterType)
@ -1198,6 +1200,7 @@ def test_should_have_next_page(graphene_settings):
class Meta:
model = Reporter
interfaces = (Node,)
fields = "__all__"
class Query(graphene.ObjectType):
all_reporters = DjangoConnectionField(ReporterType)

@ -39,7 +39,7 @@ def test_camelize():
@pytest.mark.django_db
@patch("graphene_django.utils.testing.Client.post")
def test_graphql_test_case_op_name(post_mock):
def test_graphql_test_case_operation_name(post_mock):
"""
Test that `GraphQLTestCase.query()`'s `operation_name` argument produces an `operationName` field.
"""
@ -63,8 +63,8 @@ def test_graphql_test_case_op_name(post_mock):
@pytest.mark.django_db
@patch("graphene_django.utils.testing.Client.post")
def test_graphql_query_case_op_name(post_mock):
graphql_query("query { }", op_name="QueryName")
def test_graphql_query_case_operation_name(post_mock):
graphql_query("query { }", operation_name="QueryName")
body = json.loads(post_mock.call_args.args[1])
# `operationName` field from https://graphql.org/learn/serving-over-http/#post-request
assert (

@ -58,7 +58,7 @@ setup(
keywords="api graphql protocol rest relay graphene",
packages=find_packages(exclude=["tests"]),
install_requires=[
"graphene>=3.0.0b1,<4",
"graphene>=3.0.0b5,<4",
"graphql-core>=3.1.0,<4",
"Django>=2.2",
"promise>=2.1",

Loading…
Cancel
Save