Browse Source

replace FALSE with false so that static analyzer shuts up about it

master
Andrew Dolgov 2 years ago
parent
commit
a4525d31b2
  1. 4
      classes/article.php
  2. 2
      classes/backend.php
  3. 4
      classes/feeds.php
  4. 4
      classes/pluginhost.php
  5. 2
      classes/pref/prefs.php
  6. 2
      classes/rssutils.php
  7. 2
      classes/templator.php
  8. 2
      include/autoload.php
  9. 2
      include/controls.php
  10. 12
      include/functions.php
  11. 2
      include/login_form.php
  12. 2
      include/sanity_check.php
  13. 2
      install/index.php
  14. 4
      plugins/af_comics/filters/af_comics_cad.php
  15. 2
      plugins/af_comics/filters/af_comics_comicclass.php
  16. 14
      plugins/af_comics/filters/af_comics_comicpress.php
  17. 2
      plugins/af_comics/filters/af_comics_darklegacy.php
  18. 4
      plugins/af_comics/filters/af_comics_dilbert.php
  19. 2
      plugins/af_comics/filters/af_comics_explosm.php
  20. 4
      plugins/af_comics/filters/af_comics_pa.php
  21. 2
      plugins/af_comics/filters/af_comics_pvp.php
  22. 4
      plugins/af_comics/filters/af_comics_tfd.php
  23. 2
      plugins/af_comics/filters/af_comics_twp.php
  24. 2
      plugins/af_comics/filters/af_comics_whomp.php
  25. 2
      plugins/af_comics/init.php
  26. 8
      plugins/af_psql_trgm/init.php
  27. 8
      plugins/af_readability/init.php
  28. 16
      plugins/af_redditimgur/init.php
  29. 8
      plugins/af_unburn/init.php

4
classes/article.php

@ -54,7 +54,7 @@ class Article extends Handler_Protected {
if (!$title) $title = $url;
if (!$title && !$url) return false;
if (filter_var($url, FILTER_VALIDATE_URL) === FALSE) return false;
if (filter_var($url, FILTER_VALIDATE_URL) === false) return false;
$pdo = Db::pdo();
@ -757,7 +757,7 @@ class Article extends Handler_Protected {
if (!$article_image)
foreach ($enclosures as $enc) {
if (strpos($enc["content_type"], "image/") !== FALSE) {
if (strpos($enc["content_type"], "image/") !== false) {
$article_image = $enc["content_url"];
break;
}

2
classes/backend.php

@ -42,7 +42,7 @@ class Backend extends Handler_Protected {
if (is_array($omap[$action])) {
foreach ($omap[$action] as $sequence) {
if (strpos($sequence, "|") !== FALSE) {
if (strpos($sequence, "|") !== false) {
$sequence = substr($sequence,
strpos($sequence, "|")+1,
strlen($sequence));

4
classes/feeds.php

@ -210,7 +210,7 @@ class Feeds extends Handler_Protected {
$feed_title = $qfh_ret[1];
$feed_site_url = $qfh_ret[2];
$last_error = $qfh_ret[3];
$last_updated = strpos($qfh_ret[4], '1970-') === FALSE ?
$last_updated = strpos($qfh_ret[4], '1970-') === false ?
make_local_datetime($qfh_ret[4], false) : __("Never");
$highlight_words = $qfh_ret[5];
$reply['first_id'] = $qfh_ret[6];
@ -1142,7 +1142,7 @@ class Feeds extends Handler_Protected {
return array("code" => 5, "message" => $fetch_last_error);
}
if (mb_strpos($fetch_last_content_type, "html") !== FALSE && Feeds::is_html($contents)) {
if (mb_strpos($fetch_last_content_type, "html") !== false && Feeds::is_html($contents)) {
$feedUrls = Feeds::get_feeds_from_html($url, $contents);
if (count($feedUrls) == 0) {

4
classes/pluginhost.php

@ -155,7 +155,7 @@ class PluginHost {
foreach (array_keys($this->hooks[$type]) as $prio) {
$key = array_search($sender, $this->hooks[$type][$prio]);
if ($key !== FALSE) {
if ($key !== false) {
unset($this->hooks[$type][$prio][$key]);
}
}
@ -218,7 +218,7 @@ class PluginHost {
if (file_exists($vendor_dir)) {
spl_autoload_register(function($class) use ($vendor_dir) {
if (strpos($class, '\\') !== FALSE) {
if (strpos($class, '\\') !== false) {
list ($namespace, $class_name) = explode('\\', $class, 2);
if ($namespace && $class_name) {

2
classes/pref/prefs.php

@ -866,7 +866,7 @@ class Pref_Prefs extends Handler_Protected {
PluginHost::getInstance()->get_hooks(PluginHost::HOOK_FETCH_FEED));
$feed_handlers = array_filter($feed_handlers, function($plugin) use ($feed_handler_whitelist) {
return in_array(get_class($plugin), $feed_handler_whitelist) === FALSE; });
return in_array(get_class($plugin), $feed_handler_whitelist) === false; });
if (count($feed_handlers) > 0) {
print_error(

2
classes/rssutils.php

@ -148,7 +148,7 @@ class RSSUtils {
if ($tline = $usth->fetch()) {
Debug::log(" => " . $tline["last_updated"] . ", " . $tline["id"] . " " . $tline["owner_uid"]);
if (array_search($tline["owner_uid"], $batch_owners) === FALSE)
if (array_search($tline["owner_uid"], $batch_owners) === false)
array_push($batch_owners, $tline["owner_uid"]);
$fstarted = microtime(true);

2
classes/templator.php

@ -5,7 +5,7 @@ class Templator extends MiniTemplator {
/* this reads tt-rss template from templates.local/ or templates/ if only base filename is given */
function readTemplateFromFile ($fileName) {
if (strpos($fileName, "/") === FALSE) {
if (strpos($fileName, "/") === false) {
$fileName = basename($fileName);

2
include/autoload.php

@ -5,7 +5,7 @@
$namespace = '';
$class_name = $class;
if (strpos($class, '\\') !== FALSE)
if (strpos($class, '\\') !== false)
list ($namespace, $class_name) = explode('\\', $class, 2);
$root_dir = dirname(__DIR__); // we're in tt-rss/include

2
include/controls.php

@ -244,7 +244,7 @@ function stylesheet_tag($filename, $id = false) {
function javascript_tag($filename) {
$query = "";
if (!(strpos($filename, "?") === FALSE)) {
if (!(strpos($filename, "?") === false)) {
$query = substr($filename, strpos($filename, "?")+1);
$filename = substr($filename, 0, strpos($filename, "?"));
}

12
include/functions.php

@ -326,7 +326,7 @@
$contents = substr($ret, $headers_length);
foreach ($headers as $header) {
if (strstr($header, ": ") !== FALSE) {
if (strstr($header, ": ") !== false) {
list ($key, $value) = explode(": ", $header);
if (strtolower($key) == "last-modified") {
@ -461,7 +461,7 @@
if (isset($http_response_header) && is_array($http_response_header)) {
foreach ($http_response_header as $header) {
if (strstr($header, ": ") !== FALSE) {
if (strstr($header, ": ") !== false) {
list ($key, $value) = explode(": ", $header);
$key = strtolower($key);
@ -538,7 +538,7 @@
}
while ($line = $sth->fetch()) {
if (array_search($line["pref_name"], $active_prefs) === FALSE) {
if (array_search($line["pref_name"], $active_prefs) === false) {
// print "adding " . $line["pref_name"] . "<br>";
if (get_schema_version() < 63) {
@ -1613,7 +1613,7 @@
foreach ($filter["rules"] AS $rule) {
$rule['reg_exp'] = str_replace('/', '\/', $rule["reg_exp"]);
$regexp_valid = preg_match('/' . $rule['reg_exp'] . '/',
$rule['reg_exp']) !== FALSE;
$rule['reg_exp']) !== false;
if ($regexp_valid) {
@ -1761,7 +1761,7 @@
for ($i = 0; $i < $l10n->total; $i++) {
$orig = $l10n->get_original_string($i);
if(strpos($orig, "\000") !== FALSE) { // Plural forms
if(strpos($orig, "\000") !== false) { // Plural forms
$key = explode(chr(0), $orig);
print T_js_decl($key[0], _ngettext($key[0], $key[1], 1)); // Singular
print T_js_decl($key[1], _ngettext($key[0], $key[1], 2)); // Plural
@ -1971,7 +1971,7 @@
if (strpos($url, "//") === 0)
$url = "https:" . $url;
if (filter_var($url, FILTER_VALIDATE_URL) === FALSE)
if (filter_var($url, FILTER_VALIDATE_URL) === false)
return false;
$tokens = parse_url($url);

2
include/login_form.php

@ -120,7 +120,7 @@
onblur="UtilityApp.fetchProfiles()"
value="<?php echo $_SESSION["fake_password"] ?>"/>
</fieldset>
<?php if (strpos(PLUGINS, "auth_internal") !== FALSE) { ?>
<?php if (strpos(PLUGINS, "auth_internal") !== false) { ?>
<fieldset class="align-right">
<a href="public.php?op=forgotpass"><?php echo __("I forgot my password") ?></a>
</fieldset>

2
include/sanity_check.php

@ -60,7 +60,7 @@
array_push($errors, "Please copy config.php-dist to config.php or run the installer in install/");
}
if (strpos(PLUGINS, "auth_") === FALSE) {
if (strpos(PLUGINS, "auth_") === false) {
array_push($errors, "Please enable at least one authentication module via PLUGINS constant in config.php");
}

2
install/index.php

@ -10,7 +10,7 @@
function javascript_tag($filename) {
$query = "";
if (!(strpos($filename, "?") === FALSE)) {
if (!(strpos($filename, "?") === false)) {
$query = substr($filename, strpos($filename, "?")+1);
$filename = substr($filename, 0, strpos($filename, "?"));
}

4
plugins/af_comics/filters/af_comics_cad.php

@ -6,8 +6,8 @@ class Af_Comics_Cad extends Af_ComicFilter {
}
function process(&$article) {
if (strpos($article["link"], "cad-comic.com") !== FALSE) {
if (strpos($article["title"], "News:") === FALSE) {
if (strpos($article["link"], "cad-comic.com") !== false) {
if (strpos($article["title"], "News:") === false) {
global $fetch_last_error_content;

2
plugins/af_comics/filters/af_comics_comicclass.php

@ -6,7 +6,7 @@ class Af_Comics_ComicClass extends Af_ComicFilter {
}
function process(&$article) {
if (strpos($article["guid"], "loadingartist.com") !== FALSE) {
if (strpos($article["guid"], "loadingartist.com") !== false) {
// lol at people who block clients by user agent
// oh noes my ad revenue Q_Q

14
plugins/af_comics/filters/af_comics_comicpress.php

@ -7,13 +7,13 @@ class Af_Comics_ComicPress extends Af_ComicFilter {
}
function process(&$article) {
if (strpos($article["guid"], "bunicomic.com") !== FALSE ||
strpos($article["guid"], "buttersafe.com") !== FALSE ||
strpos($article["guid"], "extrafabulouscomics.com") !== FALSE ||
strpos($article["guid"], "happyjar.com") !== FALSE ||
strpos($article["guid"], "nedroid.com") !== FALSE ||
strpos($article["guid"], "stonetoss.com") !== FALSE ||
strpos($article["guid"], "csectioncomics.com") !== FALSE) {
if (strpos($article["guid"], "bunicomic.com") !== false ||
strpos($article["guid"], "buttersafe.com") !== false ||
strpos($article["guid"], "extrafabulouscomics.com") !== false ||
strpos($article["guid"], "happyjar.com") !== false ||
strpos($article["guid"], "nedroid.com") !== false ||
strpos($article["guid"], "stonetoss.com") !== false ||
strpos($article["guid"], "csectioncomics.com") !== false) {
// lol at people who block clients by user agent
// oh noes my ad revenue Q_Q

2
plugins/af_comics/filters/af_comics_darklegacy.php

@ -7,7 +7,7 @@ class Af_Comics_DarkLegacy extends Af_ComicFilter {
function process(&$article) {
if (strpos($article["guid"], "darklegacycomics.com") !== FALSE) {
if (strpos($article["guid"], "darklegacycomics.com") !== false) {
$res = fetch_file_contents($article["link"], false, false, false,
false, false, 0,

4
plugins/af_comics/filters/af_comics_dilbert.php

@ -7,8 +7,8 @@ class Af_Comics_Dilbert extends Af_ComicFilter {
}
function process(&$article) {
if (strpos($article["link"], "dilbert.com") !== FALSE ||
strpos($article["link"], "/DilbertDailyStrip") !== FALSE) {
if (strpos($article["link"], "dilbert.com") !== false ||
strpos($article["link"], "/DilbertDailyStrip") !== false) {
$res = fetch_file_contents($article["link"], false, false, false,
false, false, 0,

2
plugins/af_comics/filters/af_comics_explosm.php

@ -7,7 +7,7 @@ class Af_Comics_Explosm extends Af_ComicFilter {
function process(&$article) {
if (strpos($article["link"], "explosm.net/comics") !== FALSE) {
if (strpos($article["link"], "explosm.net/comics") !== false) {
$doc = new DOMDocument();

4
plugins/af_comics/filters/af_comics_pa.php

@ -6,7 +6,7 @@ class Af_Comics_Pa extends Af_ComicFilter {
}
function process(&$article) {
if (strpos($article["link"], "penny-arcade.com") !== FALSE && strpos($article["title"], "Comic:") !== FALSE) {
if (strpos($article["link"], "penny-arcade.com") !== false && strpos($article["title"], "Comic:") !== false) {
$doc = new DOMDocument();
@ -22,7 +22,7 @@ class Af_Comics_Pa extends Af_ComicFilter {
return true;
}
if (strpos($article["link"], "penny-arcade.com") !== FALSE && strpos($article["title"], "News Post:") !== FALSE) {
if (strpos($article["link"], "penny-arcade.com") !== false && strpos($article["title"], "News Post:") !== false) {
$doc = new DOMDocument();
if ($doc->loadHTML(fetch_file_contents($article["link"]))) {

2
plugins/af_comics/filters/af_comics_pvp.php

@ -6,7 +6,7 @@ class Af_Comics_Pvp extends Af_ComicFilter {
}
function process(&$article) {
if (strpos($article["guid"], "pvponline.com") !== FALSE) {
if (strpos($article["guid"], "pvponline.com") !== false) {
$res = fetch_file_contents($article["link"], false, false, false,
false, false, 0,

4
plugins/af_comics/filters/af_comics_tfd.php

@ -6,8 +6,8 @@ class Af_Comics_Tfd extends Af_ComicFilter {
}
function process(&$article) {
if (strpos($article["link"], "toothpastefordinner.com") !== FALSE ||
strpos($article["link"], "marriedtothesea.com") !== FALSE) {
if (strpos($article["link"], "toothpastefordinner.com") !== false ||
strpos($article["link"], "marriedtothesea.com") !== false) {
$res = fetch_file_contents($article["link"], false, false, false,
false, false, 0,
"Mozilla/5.0 (compatible; MSIE 10.0; Windows NT 6.1; WOW64; Trident/6.0)");

2
plugins/af_comics/filters/af_comics_twp.php

@ -7,7 +7,7 @@ class Af_Comics_Twp extends Af_ComicFilter {
function process(&$article) {
if (strpos($article["link"], "threewordphrase.com") !== FALSE) {
if (strpos($article["link"], "threewordphrase.com") !== false) {
$doc = new DOMDocument();

2
plugins/af_comics/filters/af_comics_whomp.php

@ -6,7 +6,7 @@ class Af_Comics_Whomp extends Af_ComicFilter {
}
function process(&$article) {
if (strpos($article["guid"], "whompcomic.com") !== FALSE) {
if (strpos($article["guid"], "whompcomic.com") !== false) {
$res = fetch_file_contents($article["link"], false, false, false,
false, false, 0,

2
plugins/af_comics/init.php

@ -27,7 +27,7 @@ class Af_Comics extends Plugin {
foreach ($filters as $file) {
$filter_name = preg_replace("/\..*$/", "", basename($file));
if (array_search($filter_name, $names) === FALSE) {
if (array_search($filter_name, $names) === false) {
if (!class_exists($filter_name)) {
require_once $file;
}

8
plugins/af_psql_trgm/init.php

@ -228,7 +228,7 @@ class Af_Psql_Trgm extends Plugin {
if (!array($enabled_feeds)) $enabled_feeds = array();
$key = array_search($feed_id, $enabled_feeds);
$checked = $key !== FALSE ? "checked" : "";
$checked = $key !== false ? "checked" : "";
print "<fieldset>";
@ -248,11 +248,11 @@ class Af_Psql_Trgm extends Plugin {
$key = array_search($feed_id, $enabled_feeds);
if ($enable) {
if ($key === FALSE) {
if ($key === false) {
array_push($enabled_feeds, $feed_id);
}
} else {
if ($key !== FALSE) {
if ($key !== false) {
unset($enabled_feeds[$key]);
}
}
@ -272,7 +272,7 @@ class Af_Psql_Trgm extends Plugin {
if (!$enable_globally) {
$enabled_feeds = $this->host->get($this, "enabled_feeds");
$key = array_search($article["feed"]["id"], $enabled_feeds);
if ($key === FALSE) return $article;
if ($key === false) return $article;
}
$similarity = (float) $this->host->get($this, "similarity");

8
plugins/af_readability/init.php

@ -133,7 +133,7 @@ class Af_Readability extends Plugin {
if (!is_array($enabled_feeds)) $enabled_feeds = array();
$key = array_search($feed_id, $enabled_feeds);
$checked = $key !== FALSE ? "checked" : "";
$checked = $key !== false ? "checked" : "";
print "<fieldset>";
@ -153,11 +153,11 @@ class Af_Readability extends Plugin {
$key = array_search($feed_id, $enabled_feeds);
if ($enable) {
if ($key === FALSE) {
if ($key === false) {
array_push($enabled_feeds, $feed_id);
}
} else {
if ($key !== FALSE) {
if ($key !== false) {
unset($enabled_feeds[$key]);
}
}
@ -250,7 +250,7 @@ class Af_Readability extends Plugin {
if (!is_array($enabled_feeds)) return $article;
$key = array_search($article["feed"]["id"], $enabled_feeds);
if ($key === FALSE) return $article;
if ($key === false) return $article;
return $this->process_article($article);

16
plugins/af_redditimgur/init.php

@ -94,7 +94,7 @@ class Af_RedditImgur extends Plugin {
//$debug = 1;
foreach ($entries as $entry) {
if ($entry->hasAttribute("href") && strpos($entry->getAttribute("href"), "reddit.com") === FALSE) {
if ($entry->hasAttribute("href") && strpos($entry->getAttribute("href"), "reddit.com") === false) {
Debug::log("processing href: " . $entry->getAttribute("href"), Debug::$LOG_VERBOSE);
@ -140,7 +140,7 @@ class Af_RedditImgur extends Plugin {
$content_type = $this->get_content_type($source_stream);
if (strpos($content_type, "video/") !== FALSE) {
if (strpos($content_type, "video/") !== false) {
$this->handle_as_video($doc, $entry, $source_stream, $poster_url);
$found = 1;
}
@ -230,7 +230,7 @@ class Af_RedditImgur extends Plugin {
$source_stream = str_replace(".gifv", ".mp4", $entry->getAttribute("href"));
if (strpos($source_stream, "imgur.com") !== FALSE)
if (strpos($source_stream, "imgur.com") !== false)
$poster_url = str_replace(".mp4", "h.jpg", $source_stream);
$this->handle_as_video($doc, $entry, $source_stream, $poster_url);
@ -265,8 +265,8 @@ class Af_RedditImgur extends Plugin {
}
if (!$found && (preg_match("/\.(jpg|jpeg|gif|png)(\?[0-9][0-9]*)?[$\?]/i", $entry->getAttribute("href")) ||
mb_strpos($entry->getAttribute("href"), "i.reddituploads.com") !== FALSE ||
mb_strpos($this->get_content_type($entry->getAttribute("href")), "image/") !== FALSE)) {
mb_strpos($entry->getAttribute("href"), "i.reddituploads.com") !== false ||
mb_strpos($this->get_content_type($entry->getAttribute("href")), "image/") !== false)) {
Debug::log("Handling as a picture", Debug::$LOG_VERBOSE);
@ -393,7 +393,7 @@ class Af_RedditImgur extends Plugin {
function hook_article_filter($article) {
if (strpos($article["link"], "reddit.com/r/") !== FALSE) {
if (strpos($article["link"], "reddit.com/r/") !== false) {
$doc = new DOMDocument();
@$doc->loadHTML($article["content"]);
$xpath = new DOMXPath($doc);
@ -543,7 +543,7 @@ class Af_RedditImgur extends Plugin {
// do not try to embed posts linking back to other reddit posts
// readability.php requires PHP 5.6
if ($url && strpos($url, "reddit.com") === FALSE && version_compare(PHP_VERSION, '5.6.0', '>=')) {
if ($url && strpos($url, "reddit.com") === false && version_compare(PHP_VERSION, '5.6.0', '>=')) {
/* link may lead to a huge video file or whatever, we need to check content type before trying to
parse it which p much requires curl */
@ -551,7 +551,7 @@ class Af_RedditImgur extends Plugin {
$useragent_compat = "Mozilla/5.0 (compatible; MSIE 10.0; Windows NT 6.1; WOW64; Trident/6.0)";
$content_type = $this->get_content_type($url, $useragent_compat);
if ($content_type && strpos($content_type, "text/html") !== FALSE) {
if ($content_type && strpos($content_type, "text/html") !== false) {
foreach ($this->host->get_hooks(PluginHost::HOOK_GET_FULL_TEXT) as $p) {
$extracted_content = $p->hook_get_full_text($url);

8
plugins/af_unburn/init.php

@ -24,9 +24,9 @@ class Af_Unburn extends Plugin {
if (defined('NO_CURL') || !function_exists("curl_init") || ini_get("open_basedir"))
return $article;
if ((strpos($article["link"], "feedproxy.google.com") !== FALSE ||
strpos($article["link"], "/~r/") !== FALSE ||
strpos($article["link"], "feedsportal.com") !== FALSE)) {
if ((strpos($article["link"], "feedproxy.google.com") !== false ||
strpos($article["link"], "/~r/") !== false ||
strpos($article["link"], "feedsportal.com") !== false)) {
$ch = curl_init($article["link"]);
@ -52,7 +52,7 @@ class Af_Unburn extends Plugin {
$query = parse_url($real_url, PHP_URL_QUERY);
if ($query && strpos($query, "utm_source") !== FALSE) {
if ($query && strpos($query, "utm_source") !== false) {
$args = array();
parse_str($query, $args);

Loading…
Cancel
Save