Merge branch 'jc/clone-remote-name-leak-fix' into maint

"git clone --origin X" leaked piece of memory that held value read
from the clone.defaultRemoteName configuration variable, which has
been plugged.
source: <xmqqlevl4ysk.fsf@gitster.g>

* jc/clone-remote-name-leak-fix:
  clone: plug a miniscule leak
pull/1284/head
Junio C Hamano 4 months ago
commit d2b11e05e0
  1. 4
      builtin/clone.c

@ -1106,8 +1106,10 @@ int cmd_clone(int argc, const char **argv, const char *prefix)
* apply the remote name provided by --origin only after this second
* call to git_config, to ensure it overrides all config-based values.
*/
if (option_origin != NULL)
if (option_origin != NULL) {
free(remote_name);
remote_name = xstrdup(option_origin);
}
if (remote_name == NULL)
remote_name = xstrdup("origin");

Loading…
Cancel
Save