Browse Source

pack-mtimes: avoid closing a bogus file descriptor

In 94cd775a6c (pack-mtimes: support reading .mtimes files,
2022-05-20), code was added to close the file descriptor corresponding
to the mtimes file.

However, it is possible that opening that file failed, in which case we
are closing a file descriptor with the value `-1`. Let's guard that
`close()` call.

Reported by Coverity.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
pull/1007/merge
Johannes Schindelin 2 months ago committed by Junio C Hamano
parent
commit
41f1a8e6a4
  1. 3
      pack-mtimes.c

3
pack-mtimes.c

@ -89,7 +89,8 @@ cleanup:
*data_p = data;
}
close(fd);
if (fd >= 0)
close(fd);
return ret;
}

Loading…
Cancel
Save