perl: use "use warnings" instead of -w

Change the Perl scripts to turn on lexical warnings instead of setting
the global $^W variable via the -w switch.

The -w sets warnings for all code that interpreter runs, while "use
warnings" is lexically scoped. The former is probably not what the
authors wanted.

As an auxiliary benefit it's now possible to build Git with:

    PERL_PATH='/usr/bin/env perl'

Which would previously result in failures, since "#!/usr/bin/env perl -w"
doesn't work as a shebang.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
pull/6/head
Ævar Arnfjörð Bjarmason 12 years ago committed by Junio C Hamano
parent d48b284183
commit 3328acedc6
  1. 2
      contrib/examples/git-svnimport.perl
  2. 3
      contrib/fast-import/import-directories.perl
  3. 3
      git-add--interactive.perl
  4. 2
      git-archimport.perl
  5. 3
      git-cvsexportcommit.perl
  6. 2
      git-cvsimport.perl
  7. 2
      git-send-email.perl

@ -1,4 +1,4 @@
#!/usr/bin/perl -w
#!/usr/bin/perl
# This tool is copyright (c) 2005, Matthias Urlichs.
# It is released under the Gnu Public License, version 2.

@ -1,4 +1,4 @@
#!/usr/bin/perl -w
#!/usr/bin/perl
#
# Copyright 2008-2009 Peter Krefting <peter@softwolves.pp.se>
#
@ -140,6 +140,7 @@ by whitespace or other characters.
# Globals
use strict;
use warnings;
use integer;
my $crlfmode = 0;
my @revs;

@ -1,7 +1,8 @@
#!/usr/bin/perl -w
#!/usr/bin/perl
use 5.008;
use strict;
use warnings;
use Git;
binmode(STDOUT, ":raw");

@ -1,4 +1,4 @@
#!/usr/bin/perl -w
#!/usr/bin/perl
#
# This tool is copyright (c) 2005, Martin Langhoff.
# It is released under the Gnu Public License, version 2.

@ -1,7 +1,8 @@
#!/usr/bin/perl -w
#!/usr/bin/perl
use 5.008;
use strict;
use warnings;
use Getopt::Std;
use File::Temp qw(tempdir);
use Data::Dumper;

@ -1,4 +1,4 @@
#!/usr/bin/perl -w
#!/usr/bin/perl
# This tool is copyright (c) 2005, Matthias Urlichs.
# It is released under the Gnu Public License, version 2.

@ -1,4 +1,4 @@
#!/usr/bin/perl -w
#!/usr/bin/perl
#
# Copyright 2002,2005 Greg Kroah-Hartman <greg@kroah.com>
# Copyright 2005 Ryan Anderson <ryan@michonline.com>

Loading…
Cancel
Save