Merge branch 'jk/unused-annotation' into next

Annotate function parameters that are not used (but cannot be
removed for structural reasons), to prepare us to later compile
with -Wunused warning turned on.

* jk/unused-annotation:
  is_path_owned_by_current_uid(): mark "report" parameter as unused
  run-command: mark unused async callback parameters
  mark unused read_tree_recursive() callback parameters
  hashmap: mark unused callback parameters
  config: mark unused callback parameters
  streaming: mark unused virtual method parameters
  transport: mark bundle transport_options as unused
  refs: mark unused virtual method parameters
  refs: mark unused reflog callback parameters
  refs: mark unused each_ref_fn parameters
  git-compat-util: add UNUSED macro
pull/1320/head
Junio C Hamano 3 months ago
commit 2174b8c75d
  1. 2
      add-interactive.c
  2. 5
      archive-tar.c
  3. 5
      archive-zip.c
  4. 3
      archive.c
  5. 4
      attr.c
  6. 7
      bisect.c
  7. 4
      bloom.c
  8. 2
      builtin/am.c
  9. 12
      builtin/bisect--helper.c
  10. 4
      builtin/checkout.c
  11. 2
      builtin/commit-graph.c
  12. 8
      builtin/config.c
  13. 5
      builtin/describe.c
  14. 10
      builtin/difftool.c
  15. 2
      builtin/fast-export.c
  16. 2
      builtin/fast-import.c
  17. 9
      builtin/fetch.c
  18. 12
      builtin/fsck.c
  19. 5
      builtin/gc.c
  20. 7
      builtin/log.c
  21. 13
      builtin/ls-tree.c
  22. 2
      builtin/multi-pack-index.c
  23. 3
      builtin/name-rev.c
  24. 12
      builtin/pack-objects.c
  25. 4
      builtin/receive-pack.c
  26. 3
      builtin/reflog.c
  27. 14
      builtin/remote.c
  28. 4
      builtin/repack.c
  29. 6
      builtin/rev-parse.c
  30. 6
      builtin/show-branch.c
  31. 7
      builtin/show-ref.c
  32. 9
      builtin/stash.c
  33. 5
      builtin/submodule--helper.c
  34. 2
      color.c
  35. 4
      commit-graph.c
  36. 5
      commit.c
  37. 2
      compat/terminal.c
  38. 7
      config.c
  39. 4
      convert.c
  40. 4
      delta-islands.c
  41. 5
      diff.c
  42. 4
      dir.c
  43. 4
      environment.c
  44. 14
      fetch-pack.c
  45. 13
      git-compat-util.h
  46. 2
      gpg-interface.c
  47. 10
      hashmap.c
  48. 5
      help.c
  49. 2
      http-backend.c
  50. 2
      ident.c
  51. 3
      ll-merge.c
  52. 3
      log-tree.c
  53. 3
      ls-refs.c
  54. 12
      merge-recursive.c
  55. 4
      name-hash.c
  56. 3
      negotiator/default.c
  57. 3
      negotiator/skipping.c
  58. 5
      notes.c
  59. 10
      object-name.c
  60. 2
      object-store.h
  61. 2
      oidmap.c
  62. 2
      packfile.c
  63. 3
      pager.c
  64. 2
      patch-ids.c
  65. 3
      pretty.c
  66. 6
      range-diff.c
  67. 2
      ref-filter.c
  68. 16
      reflog.c
  69. 23
      refs.c
  70. 14
      refs/files-backend.c
  71. 6
      refs/iterator.c
  72. 14
      refs/packed-backend.c
  73. 22
      remote.c
  74. 3
      replace-object.c
  75. 18
      revision.c
  76. 2
      send-pack.c
  77. 5
      sequencer.c
  78. 3
      server-info.c
  79. 12
      shallow.c
  80. 6
      streaming.c
  81. 4
      strmap.c
  82. 4
      sub-process.c
  83. 8
      submodule-config.c
  84. 13
      submodule.c
  85. 2
      t/helper/test-config.c
  86. 4
      t/helper/test-ref-store.c
  87. 2
      t/helper/test-userdiff.c
  88. 6
      trailer.c
  89. 2
      transport.c
  90. 7
      upload-pack.c
  91. 6
      walker.c
  92. 14
      wt-status.c

@ -430,7 +430,7 @@ struct pathname_entry {
struct file_item *item;
};
static int pathname_entry_cmp(const void *unused_cmp_data,
static int pathname_entry_cmp(const void *UNUSED(cmp_data),
const struct hashmap_entry *he1,
const struct hashmap_entry *he2,
const void *name)

@ -366,7 +366,8 @@ static struct archiver *find_tar_filter(const char *name, size_t len)
return NULL;
}
static int tar_filter_config(const char *var, const char *value, void *data)
static int tar_filter_config(const char *var, const char *value,
void *UNUSED(data))
{
struct archiver *ar;
const char *name;
@ -420,7 +421,7 @@ static int git_tar_config(const char *var, const char *value, void *cb)
return tar_filter_config(var, value, cb);
}
static int write_tar_archive(const struct archiver *ar,
static int write_tar_archive(const struct archiver *UNUSED(ar),
struct archiver_args *args)
{
int err = 0;

@ -612,12 +612,13 @@ static void dos_time(timestamp_t *timestamp, int *dos_date, int *dos_time)
*dos_time = tm.tm_sec / 2 + tm.tm_min * 32 + tm.tm_hour * 2048;
}
static int archive_zip_config(const char *var, const char *value, void *data)
static int archive_zip_config(const char *var, const char *value,
void *UNUSED(data))
{
return userdiff_config(var, value);
}
static int write_zip_archive(const struct archiver *ar,
static int write_zip_archive(const struct archiver *UNUSED(ar),
struct archiver_args *args)
{
int err;

@ -382,7 +382,8 @@ struct path_exists_context {
struct archiver_args *args;
};
static int reject_entry(const struct object_id *oid, struct strbuf *base,
static int reject_entry(const struct object_id *UNUSED(oid),
struct strbuf *base,
const char *filename, unsigned mode,
void *context)
{

@ -61,10 +61,10 @@ struct attr_hash_entry {
};
/* attr_hashmap comparison function */
static int attr_hash_entry_cmp(const void *unused_cmp_data,
static int attr_hash_entry_cmp(const void *UNUSED(cmp_data),
const struct hashmap_entry *eptr,
const struct hashmap_entry *entry_or_key,
const void *unused_keydata)
const void *UNUSED(keydata))
{
const struct attr_hash_entry *a, *b;

@ -441,7 +441,7 @@ void find_bisection(struct commit_list **commit_list, int *reaches,
}
static int register_ref(const char *refname, const struct object_id *oid,
int flags, void *cb_data)
int UNUSED(flags), void *UNUSED(cb_data))
{
struct strbuf good_prefix = STRBUF_INIT;
strbuf_addstr(&good_prefix, term_good);
@ -1160,8 +1160,9 @@ int estimate_bisect_steps(int all)
return (e < 3 * x) ? n : n - 1;
}
static int mark_for_removal(const char *refname, const struct object_id *oid,
int flag, void *cb_data)
static int mark_for_removal(const char *refname,
const struct object_id *UNUSED(oid),
int UNUSED(flag), void *cb_data)
{
struct string_list *refs = cb_data;
char *ref = xstrfmt("refs/bisect%s", refname);

@ -163,10 +163,10 @@ void init_bloom_filters(void)
init_bloom_filter_slab(&bloom_filters);
}
static int pathmap_cmp(const void *hashmap_cmp_fn_data,
static int pathmap_cmp(const void *UNUSED(hashmap_cmp_fn_data),
const struct hashmap_entry *eptr,
const struct hashmap_entry *entry_or_key,
const void *keydata)
const void *UNUSED(keydata))
{
const struct pathmap_hash_entry *e1, *e2;

@ -2301,7 +2301,7 @@ static int parse_opt_show_current_patch(const struct option *opt, const char *ar
return 0;
}
static int git_am_config(const char *k, const char *v, void *cb)
static int git_am_config(const char *k, const char *v, void *UNUSED(cb))
{
int status;

@ -329,8 +329,9 @@ static int check_and_set_terms(struct bisect_terms *terms, const char *cmd)
return 0;
}
static int inc_nr(const char *refname, const struct object_id *oid,
int flag, void *cb_data)
static int inc_nr(const char *UNUSED(refname),
const struct object_id *UNUSED(oid),
int UNUSED(flag), void *cb_data)
{
unsigned int *nr = (unsigned int *)cb_data;
(*nr)++;
@ -518,7 +519,7 @@ finish:
}
static int add_bisect_ref(const char *refname, const struct object_id *oid,
int flags, void *cb)
int UNUSED(flags), void *cb)
{
struct add_bisect_ref_data *data = cb;
@ -1134,8 +1135,9 @@ static int bisect_visualize(struct bisect_terms *terms, const char **argv, int a
return res;
}
static int get_first_good(const char *refname, const struct object_id *oid,
int flag, void *cb_data)
static int get_first_good(const char *UNUSED(refname),
const struct object_id *oid,
int UNUSED(flag), void *cb_data)
{
oidcpy(cb_data, oid);
return 1;

@ -125,7 +125,7 @@ static int post_checkout_hook(struct commit *old_commit, struct commit *new_comm
}
static int update_some(const struct object_id *oid, struct strbuf *base,
const char *pathname, unsigned mode, void *context)
const char *pathname, unsigned mode, void *UNUSED(context))
{
int len;
struct cache_entry *ce;
@ -990,7 +990,7 @@ static void update_refs_for_switch(const struct checkout_opts *opts,
static int add_pending_uninteresting_ref(const char *refname,
const struct object_id *oid,
int flags, void *cb_data)
int UNUSED(flags), void *cb_data)
{
add_pending_oid(cb_data, refname, oid, UNINTERESTING);
return 0;

@ -179,7 +179,7 @@ static int write_option_max_new_filters(const struct option *opt,
}
static int git_commit_graph_write_config(const char *var, const char *value,
void *cb)
void *UNUSED(cb))
{
if (!strcmp(var, "commitgraph.maxnewfilters"))
write_opts.max_new_filters = git_config_int(var, value);

@ -207,7 +207,8 @@ static void show_config_scope(struct strbuf *buf)
strbuf_addch(buf, term);
}
static int show_all_config(const char *key_, const char *value_, void *cb)
static int show_all_config(const char *key_, const char *value_,
void *UNUSED(cb))
{
if (show_origin || show_scope) {
struct strbuf buf = STRBUF_INIT;
@ -458,7 +459,8 @@ static const char *get_color_slot;
static const char *get_colorbool_slot;
static char parsed_color[COLOR_MAXLEN];
static int git_get_color_config(const char *var, const char *value, void *cb)
static int git_get_color_config(const char *var, const char *value,
void *UNUSED(cb))
{
if (!strcmp(var, get_color_slot)) {
if (!value)
@ -490,7 +492,7 @@ static int get_colorbool_found;
static int get_diff_color_found;
static int get_color_ui_found;
static int git_get_colorbool_config(const char *var, const char *value,
void *cb)
void *UNUSED(data))
{
if (!strcmp(var, get_colorbool_slot))
get_colorbool_found = git_config_colorbool(var, value);

@ -63,7 +63,7 @@ static const char *prio_names[] = {
N_("head"), N_("lightweight"), N_("annotated"),
};
static int commit_name_neq(const void *unused_cmp_data,
static int commit_name_neq(const void *UNUSED(cmp_data),
const struct hashmap_entry *eptr,
const struct hashmap_entry *entry_or_key,
const void *peeled)
@ -140,7 +140,8 @@ static void add_to_known_names(const char *path,
}
}
static int get_name(const char *path, const struct object_id *oid, int flag, void *cb_data)
static int get_name(const char *path, const struct object_id *oid,
int UNUSED(flag), void *UNUSED(cb_data))
{
int is_tag = 0;
struct object_id peeled;

@ -125,10 +125,10 @@ struct working_tree_entry {
char path[FLEX_ARRAY];
};
static int working_tree_entry_cmp(const void *unused_cmp_data,
static int working_tree_entry_cmp(const void *UNUSED(cmp_data),
const struct hashmap_entry *eptr,
const struct hashmap_entry *entry_or_key,
const void *unused_keydata)
const void *UNUSED(keydata))
{
const struct working_tree_entry *a, *b;
@ -148,10 +148,10 @@ struct pair_entry {
const char path[FLEX_ARRAY];
};
static int pair_cmp(const void *unused_cmp_data,
static int pair_cmp(const void *UNUSED(cmp_data),
const struct hashmap_entry *eptr,
const struct hashmap_entry *entry_or_key,
const void *unused_keydata)
const void *UNUSED(keydata))
{
const struct pair_entry *a, *b;
@ -184,7 +184,7 @@ struct path_entry {
char path[FLEX_ARRAY];
};
static int path_entry_cmp(const void *unused_cmp_data,
static int path_entry_cmp(const void *UNUSED(cmp_data),
const struct hashmap_entry *eptr,
const struct hashmap_entry *entry_or_key,
const void *key)

@ -119,7 +119,7 @@ struct anonymized_entry_key {
size_t orig_len;
};
static int anonymized_entry_cmp(const void *unused_cmp_data,
static int anonymized_entry_cmp(const void *UNUSED(cmp_data),
const struct hashmap_entry *eptr,
const struct hashmap_entry *entry_or_key,
const void *keydata)

@ -46,7 +46,7 @@ struct object_entry {
depth : DEPTH_BITS;
};
static int object_entry_hashcmp(const void *map_data,
static int object_entry_hashcmp(const void *UNUSED(map_data),
const struct hashmap_entry *eptr,
const struct hashmap_entry *entry_or_key,
const void *keydata)

@ -301,7 +301,7 @@ struct refname_hash_entry {
char refname[FLEX_ARRAY];
};
static int refname_hash_entry_cmp(const void *hashmap_cmp_fn_data,
static int refname_hash_entry_cmp(const void *UNUSED(hashmap_cmp_fn_data),
const struct hashmap_entry *eptr,
const struct hashmap_entry *entry_or_key,
const void *keydata)
@ -329,7 +329,7 @@ static struct refname_hash_entry *refname_hash_add(struct hashmap *map,
static int add_one_refname(const char *refname,
const struct object_id *oid,
int flag, void *cbdata)
int UNUSED(flag), void *cbdata)
{
struct hashmap *refname_map = cbdata;
@ -1464,8 +1464,9 @@ static void set_option(struct transport *transport, const char *name, const char
}
static int add_oid(const char *refname, const struct object_id *oid, int flags,
void *cb_data)
static int add_oid(const char *UNUSED(refname),
const struct object_id *oid,
int UNUSED(flags), void *cb_data)
{
struct oid_array *oids = cb_data;

@ -488,8 +488,9 @@ static void fsck_handle_reflog_oid(const char *refname, struct object_id *oid,
}
static int fsck_handle_reflog_ent(struct object_id *ooid, struct object_id *noid,
const char *email, timestamp_t timestamp, int tz,
const char *message, void *cb_data)
const char *UNUSED(email),
timestamp_t timestamp, int UNUSED(tz),
const char *UNUSED(message), void *cb_data)
{
const char *refname = cb_data;
@ -502,8 +503,9 @@ static int fsck_handle_reflog_ent(struct object_id *ooid, struct object_id *noid
return 0;
}
static int fsck_handle_reflog(const char *logname, const struct object_id *oid,
int flag, void *cb_data)
static int fsck_handle_reflog(const char *logname,
const struct object_id *UNUSED(oid),
int UNUSED(flag), void *cb_data)
{
struct strbuf refname = STRBUF_INIT;
@ -514,7 +516,7 @@ static int fsck_handle_reflog(const char *logname, const struct object_id *oid,
}
static int fsck_handle_ref(const char *refname, const struct object_id *oid,
int flag, void *cb_data)
int UNUSED(flag), void *UNUSED(cb_data))
{
struct object *obj;

@ -782,8 +782,9 @@ struct cg_auto_data {
int limit;
};
static int dfs_on_ref(const char *refname,
const struct object_id *oid, int flags,
static int dfs_on_ref(const char *UNUSED(refname),
const struct object_id *oid,
int UNUSED(flags),
void *cb_data)
{
struct cg_auto_data *data = (struct cg_auto_data *)cb_data;

@ -697,9 +697,10 @@ static int show_tag_object(const struct object_id *oid, struct rev_info *rev)
return 0;
}
static int show_tree_object(const struct object_id *oid,
struct strbuf *base,
const char *pathname, unsigned mode, void *context)
static int show_tree_object(const struct object_id *UNUSED(oid),
struct strbuf *UNUSED(base),
const char *pathname, unsigned mode,
void *context)
{
FILE *file = context;
fprintf(file, "%s%s\n", pathname, S_ISDIR(mode) ? "/" : "");

@ -142,7 +142,7 @@ static int show_recursive(const char *base, size_t baselen, const char *pathname
}
static int show_tree_fmt(const struct object_id *oid, struct strbuf *base,
const char *pathname, unsigned mode, void *context)
const char *pathname, unsigned mode, void *UNUSED(context))
{
size_t baselen;
int recurse = 0;
@ -213,7 +213,7 @@ static void show_tree_common_default_long(struct strbuf *base,
static int show_tree_default(const struct object_id *oid, struct strbuf *base,
const char *pathname, unsigned mode,
void *context)
void *UNUSED(context))
{
int early;
int recurse;
@ -230,7 +230,8 @@ static int show_tree_default(const struct object_id *oid, struct strbuf *base,
}
static int show_tree_long(const struct object_id *oid, struct strbuf *base,
const char *pathname, unsigned mode, void *context)
const char *pathname, unsigned mode,
void *UNUSED(context))
{
int early;
int recurse;
@ -259,7 +260,8 @@ static int show_tree_long(const struct object_id *oid, struct strbuf *base,
}
static int show_tree_name_only(const struct object_id *oid, struct strbuf *base,
const char *pathname, unsigned mode, void *context)
const char *pathname, unsigned mode,
void *UNUSED(context))
{
int early;
int recurse;
@ -279,7 +281,8 @@ static int show_tree_name_only(const struct object_id *oid, struct strbuf *base,
}
static int show_tree_object(const struct object_id *oid, struct strbuf *base,
const char *pathname, unsigned mode, void *context)
const char *pathname, unsigned mode,
void *UNUSED(context))
{
int early;
int recurse;

@ -78,7 +78,7 @@ static struct option *add_common_options(struct option *prev)
}
static int git_multi_pack_index_write_config(const char *var, const char *value,
void *cb)
void *UNUSED(cb))
{
if (!strcmp(var, "pack.writebitmaphashcache")) {
if (git_config_bool(var, value))

@ -344,7 +344,8 @@ static int cmp_by_tag_and_age(const void *a_, const void *b_)
return a->taggerdate != b->taggerdate;
}
static int name_ref(const char *path, const struct object_id *oid, int flags, void *cb_data)
static int name_ref(const char *path, const struct object_id *oid,
int UNUSED(flags), void *cb_data)
{
struct object *o = parse_object(the_repository, oid);
struct name_ref_data *data = cb_data;

@ -759,8 +759,8 @@ static enum write_one_status write_one(struct hashfile *f,
return WRITE_ONE_WRITTEN;
}
static int mark_tagged(const char *path, const struct object_id *oid, int flag,
void *cb_data)
static int mark_tagged(const char *UNUSED(path), const struct object_id *oid,
int UNUSED(flag), void *UNUSED(cb_data))
{
struct object_id peeled;
struct object_entry *entry = packlist_find(&to_pack, oid);
@ -3035,7 +3035,8 @@ static void add_tag_chain(const struct object_id *oid)
}
}
static int add_ref_tag(const char *tag, const struct object_id *oid, int flag, void *cb_data)
static int add_ref_tag(const char *UNUSED(tag), const struct object_id *oid,
int UNUSED(flag), void *UNUSED(cb_data))
{
struct object_id peeled;
@ -3950,8 +3951,9 @@ static void record_recent_commit(struct commit *commit, void *data)
}
static int mark_bitmap_preferred_tip(const char *refname,
const struct object_id *oid, int flags,
void *_data)
const struct object_id *oid,
int UNUSED(flags),
void *UNUSED(data))
{
struct object_id peeled;
struct object *object;

@ -291,7 +291,7 @@ static void show_ref(const char *path, const struct object_id *oid)
}
static int show_ref_cb(const char *path_full, const struct object_id *oid,
int flag, void *data)
int UNUSED(flag), void *data)
{
struct oidset *seen = data;
const char *path = strip_namespace(path_full);
@ -465,7 +465,7 @@ static void rp_error(const char *err, ...)
va_end(params);
}
static int copy_to_sideband(int in, int out, void *arg)
static int copy_to_sideband(int in, int UNUSED(out), void *UNUSED(arg))
{
char data[128];
int keepalive_active = 0;

@ -56,7 +56,8 @@ struct worktree_reflogs {
struct string_list reflogs;
};
static int collect_reflog(const char *ref, const struct object_id *oid, int unused, void *cb_data)
static int collect_reflog(const char *ref, const struct object_id *UNUSED(oid),
int UNUSED(flags), void *cb_data)
{
struct worktree_reflogs *cb = cb_data;
struct worktree *worktree = cb->worktree;

@ -264,7 +264,8 @@ static const char *abbrev_ref(const char *name, const char *prefix)
}
#define abbrev_branch(name) abbrev_ref((name), "refs/heads/")
static int config_read_branches(const char *key, const char *value, void *cb)
static int config_read_branches(const char *key, const char *value,
void *UNUSED(data))
{
const char *orig_key = key;
char *name;
@ -538,7 +539,8 @@ struct branches_for_remote {
};
static int add_branch_for_removal(const char *refname,
const struct object_id *oid, int flags, void *cb_data)
const struct object_id *UNUSED(oid),
int UNUSED(flags), void *cb_data)
{
struct branches_for_remote *branches = cb_data;
struct refspec_item refspec;
@ -580,7 +582,8 @@ struct rename_info {
};
static int read_remote_branches(const char *refname,
const struct object_id *oid, int flags, void *cb_data)
const struct object_id *UNUSED(oid),
int UNUSED(flags), void *cb_data)
{
struct rename_info *rename = cb_data;
struct strbuf buf = STRBUF_INIT;
@ -953,7 +956,8 @@ static void free_remote_ref_states(struct ref_states *states)
}
static int append_ref_to_tracked_list(const char *refname,
const struct object_id *oid, int flags, void *cb_data)
const struct object_id *UNUSED(oid),
int flags, void *cb_data)
{
struct ref_states *states = cb_data;
struct refspec_item refspec;
@ -1482,7 +1486,7 @@ static int prune(int argc, const char **argv, const char *prefix)
return result;
}
static int get_remote_default(const char *key, const char *value, void *priv)
static int get_remote_default(const char *key, const char *UNUSED(value), void *priv)
{
if (strcmp(key, "remotes.default") == 0) {
int *found = priv;

@ -514,9 +514,9 @@ struct midx_snapshot_ref_data {
int preferred;
};
static int midx_snapshot_ref_one(const char *refname,
static int midx_snapshot_ref_one(const char *UNUSED(refname),
const struct object_id *oid,
int flag, void *_data)
int UNUSED(flag), void *_data)
{
struct midx_snapshot_ref_data *data = _data;
struct object_id peeled;

@ -195,7 +195,8 @@ static int show_default(void)
return 0;
}
static int show_reference(const char *refname, const struct object_id *oid, int flag, void *cb_data)
static int show_reference(const char *refname, const struct object_id *oid,
int UNUSED(flag), void *UNUSED(cb_data))
{
if (ref_excluded(ref_excludes, refname))
return 0;
@ -203,7 +204,8 @@ static int show_reference(const char *refname, const struct object_id *oid, int
return 0;
}
static int anti_reference(const char *refname, const struct object_id *oid, int flag, void *cb_data)
static int anti_reference(const char *refname, const struct object_id *oid,
int UNUSED(flag), void *UNUSED(cb_data))
{
show_rev(REVERSED, oid, refname);
return 0;

@ -404,7 +404,7 @@ static int append_ref(const char *refname, const struct object_id *oid,
}
static int append_head_ref(const char *refname, const struct object_id *oid,
int flag, void *cb_data)
int UNUSED(flag), void *UNUSED(cb_data))
{
struct object_id tmp;
int ofs = 11;
@ -419,7 +419,7 @@ static int append_head_ref(const char *refname, const struct object_id *oid,
}
static int append_remote_ref(const char *refname, const struct object_id *oid,
int flag, void *cb_data)
int UNUSED(flag), void *UNUSED(cb_data))
{
struct object_id tmp;
int ofs = 13;
@ -434,7 +434,7 @@ static int append_remote_ref(const char *refname, const struct object_id *oid,
}
static int append_tag_ref(const char *refname, const struct object_id *oid,
int flag, void *cb_data)
int UNUSED(flag), void *UNUSED(cb_data))
{
if (!starts_with(refname, "refs/tags/"))
return 0;

@ -47,7 +47,7 @@ static void show_one(const char *refname, const struct object_id *oid)
}
static int show_ref(const char *refname, const struct object_id *oid,
int flag, void *cbdata)
int UNUSED(flag), void *UNUSED(cbdata))
{
if (show_head && !strcmp(refname, "HEAD"))
goto match;
@ -77,8 +77,9 @@ match:
return 0;
}
static int add_existing(const char *refname, const struct object_id *oid,
int flag, void *cbdata)
static int add_existing(const char *refname,
const struct object_id *UNUSED(oid),
int UNUSED(flag), void *cbdata)
{
struct string_list *list = (struct string_list *)cbdata;
string_list_insert(list, refname);

@ -638,9 +638,12 @@ cleanup:
return ret;
}
static int reject_reflog_ent(struct object_id *ooid, struct object_id *noid,
const char *email, timestamp_t timestamp, int tz,
const char *message, void *cb_data)
static int reject_reflog_ent(struct object_id *UNUSED(ooid),
struct object_id *UNUSED(noid),
const char *UNUSED(email),
timestamp_t UNUSED(timestamp),
int UNUSED(tz), const char *UNUSED(message),
void *UNUSED(cb_data))
{
return 1;
}

@ -622,8 +622,9 @@ static void print_status(unsigned int flags, char state, const char *path,
printf("\n");
}
static int handle_submodule_head_ref(const char *refname,
const struct object_id *oid, int flags,
static int handle_submodule_head_ref(const char *UNUSED(refname),
const struct object_id *oid,
int UNUSED(flags),
void *cb_data)
{
struct object_id *output = cb_data;

@ -415,7 +415,7 @@ int want_color_fd(int fd, int var)
return var;
}
int git_color_config(const char *var, const char *value, void *cb)
int git_color_config(const char *var, const char *value, void *UNUSED(cb))
{
if (!strcmp(var, "color.ui")) {
git_use_color_default = git_config_colorbool(var, value);

@ -1639,9 +1639,9 @@ struct refs_cb_data {
struct progress *progress;
};
static int add_ref_to_set(const char *refname,
static int add_ref_to_set(const char *UNUSED(refname),
const struct object_id *oid,
int flags, void *cb_data)
int UNUSED(flags), void *cb_data)
{
struct object_id peeled;
struct refs_cb_data *data = (struct refs_cb_data *)cb_data;

@ -951,8 +951,9 @@ static void add_one_commit(struct object_id *oid, struct rev_collect *revs)
}
static int collect_one_reflog_ent(struct object_id *ooid, struct object_id *noid,
const char *ident, timestamp_t timestamp,
int tz, const char *message, void *cbdata)
const char *UNUSED(ident),
timestamp_t UNUSED(timestamp), int UNUSED(tz),
const char *UNUSED(message), void *cbdata)
{
struct rev_collect *revs = cbdata;

@ -477,7 +477,7 @@ struct escape_sequence_entry {
char sequence[FLEX_ARRAY];
};
static int sequence_entry_cmp(const void *hashmap_cmp_fn_data,
static int sequence_entry_cmp(const void *UNUSED(hashmap_cmp_fn_data),
const struct escape_sequence_entry *e1,
const struct escape_sequence_entry *e2,
const void *keydata)

@ -362,7 +362,8 @@ static void populate_remote_urls(struct config_include_data *inc)
current_parsing_scope = store_scope;
}
static int forbid_remote_url(const char *var, const char *value, void *data)
static int forbid_remote_url(const char *var, const char *UNUSED(value),
void *UNUSED(data))
{
const char *remote_name;
size_t remote_name_len;
@ -2337,10 +2338,10 @@ static int configset_add_value(struct config_set *cs, const char *key, const cha
return 0;
}
static int config_set_element_cmp(const void *unused_cmp_data,
static int config_set_element_cmp(const void *UNUSED(cmp_data),
const struct hashmap_entry *eptr,
const struct hashmap_entry *entry_or_key,
const void *unused_keydata)
const void *UNUSED(keydata))
{
const struct config_set_element *e1, *e2;

@ -619,7 +619,7 @@ struct filter_params {
const char *path;
};
static int filter_buffer_or_fd(int in, int out, void *data)
static int filter_buffer_or_fd(int UNUSED(in), int out, void *data)
{
/*
* Spawn cmd and feed the buffer contents through its stdin.
@ -1008,7 +1008,7 @@ static int apply_filter(const char *path, const char *src, size_t len,
return 0;
}
static int read_convert_config(const char *var, const char *value, void *cb)
static int read_convert_config(const char *var, const char *value, void *UNUSED(cb))
{
const char *key, *name;
size_t namelen;

@ -316,7 +316,7 @@ static regex_t *island_regexes;
static unsigned int island_regexes_alloc, island_regexes_nr;
static const char *core_island_name;
static int island_config_callback(const char *k, const char *v, void *cb)
static int island_config_callback(const char *k, const char *v, void *UNUSED(cb))
{
if (!strcmp(k, "pack.island")) {
struct strbuf re = STRBUF_INIT;
@ -365,7 +365,7 @@ static void add_ref_to_island(const char *island_name, const struct object_id *o
}
static int find_island_for_ref(const char *refname, const struct object_id *oid,
int flags, void *data)
int UNUSED(flags), void *UNUSED(data))
{
/*
* We should advertise 'ARRAY_SIZE(matches) - 2' as the max,

@ -264,7 +264,8 @@ void init_diff_ui_defaults(void)
diff_detect_rename_default = DIFF_DETECT_RENAME;
}
int git_diff_heuristic_config(const char *var, const char *value, void *cb)
int git_diff_heuristic_config(const char *var, const char *value,
void *UNUSED(cb))
{
if (!strcmp(var, "diff.indentheuristic"))
diff_indent_heuristic = git_config_bool(var, value);
@ -916,7 +917,7 @@ struct interned_diff_symbol {
static int interned_diff_symbol_cmp(const void *hashmap_cmp_fn_data,
const struct hashmap_entry *eptr,
const struct hashmap_entry *entry_or_key,
const void *keydata)
const void *UNUSED(keydata))
{
const struct diff_options *diffopt = hashmap_cmp_fn_data;
const struct emitted_diff_symbol *a, *b;

@ -655,10 +655,10 @@ void parse_path_pattern(const char **pattern,
*patternlen = len;
}
int pl_hashmap_cmp(const void *unused_cmp_data,
int pl_hashmap_cmp(const void *UNUSED(cmp_data),
const struct hashmap_entry *a,
const struct hashmap_entry *b,
const void *key)
const void *UNUSED(key))
{
const struct pattern_entry *ee1 =
container_of(a, struct pattern_entry, ent);

@ -334,10 +334,10 @@ static void set_git_dir_1(const char *path)
setup_git_env(path);
}
static void update_relative_gitdir(const char *name,
static void update_relative_gitdir(const char *UNUSED(name),
const char *old_cwd,
const char *new_cwd,
void *data)
void *UNUSED(data))
{
char *path = reparent_relative_path(old_cwd, new_cwd, get_git_dir());
struct tmp_objdir *tmp_objdir = tmp_objdir_unapply_primary_odb();

@ -176,8 +176,10 @@ static int rev_list_insert_ref(struct fetch_negotiator *negotiator,
return 0;
}
static int rev_list_insert_ref_oid(const char *refname, const struct object_id *oid,
int flag, void *cb_data)
static int rev_list_insert_ref_oid(const char *UNUSED(refname),
const struct object_id *oid,
int UNUSED(flag),
void *cb_data)
{
return rev_list_insert_ref(cb_data, oid);
}
@ -600,8 +602,10 @@ static int mark_complete(const struct object_id *oid)
return 0;
}
static int mark_complete_oid(const char *refname, const struct object_id *oid,
int flag, void *cb_data)
static int mark_complete_oid(const char *UNUSED(refname),
const struct object_id *oid,
int UNUSED(flag),
void *UNUSED(cb_data))
{
return mark_complete(oid);
}
@ -839,7 +843,7 @@ static int everything_local(struct fetch_pack_args *args,
return retval;
}
static int sideband_demux(int in, int out, void *data)
static int sideband_demux(int UNUSED(in), int out, void *data)
{
int *xd = data;
int ret;

@ -189,6 +189,12 @@ struct strbuf;
#define _NETBSD_SOURCE 1
#define _SGI_SOURCE 1
#if defined(__GNUC__)
#define UNUSED(var) UNUSED_##var __attribute__((unused))
#else
#define UNUSED(var) UNUSED_##var
#endif
#if defined(WIN32) && !defined(__CYGWIN__) /* Both MinGW and MSVC */
# if !defined(_WIN32_WINNT)
# define _WIN32_WINNT 0x0600
@ -398,7 +404,9 @@ typedef uintmax_t timestamp_t;
#endif
#ifndef platform_core_config
static inline int noop_core_config(const char *var, const char *value, void *cb)
static inline int noop_core_config(const char *UNUSED(var),
const char *UNUSED(value),
void *UNUSED(cb))
{
return 0;
}
@ -491,7 +499,8 @@ static inline void extract_id_from_env(const char *env, uid_t *id)
}
}
static inline int is_path_owned_by_current_uid(const char *path, struct strbuf *report)
static inline int is_path_owned_by_current_uid(const char *path,
struct strbuf *UNUSED(report))
{
struct stat st;
uid_t euid;

@ -699,7 +699,7 @@ void set_signing_key(const char *key)
configured_signing_key = xstrdup(key);
}
int git_gpg_config(const char *var, const char *value, void *cb)
int git_gpg_config(const char *var, const char *value, void *UNUSED(cb))
{
struct gpg_format *fmt = NULL;
char *fmtname = NULL;

@ -142,10 +142,10 @@ static inline struct hashmap_entry **find_entry_ptr(const struct hashmap *map,
return e;
}
static int always_equal(const void *unused_cmp_data,
const struct hashmap_entry *unused1,
const struct hashmap_entry *unused2,
const void *unused_keydata)
static int always_equal(const void *UNUSED(cmp_data),
const struct hashmap_entry *UNUSED(entry1),
const struct hashmap_entry *UNUSED(entry2),
const void *UNUSED(keydata))
{
return 0;
}
@ -313,7 +313,7 @@ struct pool_entry {
unsigned char data[FLEX_ARRAY];
};
static int pool_entry_cmp(const void *unused_cmp_data,
static int pool_entry_cmp(const void *UNUSED(cmp_data),
const struct hashmap_entry *eptr,
const struct hashmap_entry *entry_or_key,
const void *keydata)

@ -781,8 +781,9 @@ struct similar_ref_cb {
struct string_list *similar_refs;
};
static int append_similar_ref(const char *refname, const struct object_id *oid,
int flags, void *cb_data)
static int append_similar_ref(const char *refname,
const struct object_id *UNUSED(oid),
int UNUSED(flags), void *cb_data)
{
struct similar_ref_cb *cb = (struct similar_ref_cb *)(cb_data);
char *branch = strrchr(refname, '/') + 1;

@ -505,7 +505,7 @@ static void run_service(const char **argv, int buffer_input)
}
static int show_text_ref(const char *name, const struct object_id *oid,
int flag, void *cb_data)
int UNUSED(flag), void *cb_data)
{
const char *name_nons = strip_namespace(name);
struct strbuf *buf = cb_data;

@ -668,7 +668,7 @@ static int set_ident(const char *var, const char *value)
return 0;
}
int git_ident_config(const char *var, const char *value, void *data)
int git_ident_config(const char *var, const char *value, void *UNUSED(data))
{
if (!strcmp(var, "user.useconfigonly")) {
ident_use_config_only = git_config_bool(var, value);

@ -249,7 +249,8 @@ static enum ll_merge_result ll_ext_merge(const struct ll_merge_driver *fn,
static struct ll_merge_driver *ll_user_merge, **ll_user_merge_tail;
static const char *default_ll_merge;
static int read_merge_config(const char *var, const char *value, void *cb)
static int read_merge_config(const char *var, const char *value,
void *UNUSED(cb))
{
struct ll_merge_driver *fn;
const char *key, *name;